Ensure logs entries are integer during delta loading#221
Merged
RasmusSkytte merged 3 commits intomainfrom Mar 3, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
This PR fixes an issue identified by @LasseEngboChr when delta loading.
When counting updates during delta loading, the backend may return a data-type that gets mistranslated when writing to the log. In this case, the counts were returned as
int64which was incorrectly translated as a float when writing to the log.Approach
Count data is forced to R integers before writing
Known issues
N/A
Checklist
NEWS.md